From d34076c4d4b292750544ae7ce4b1556530ad347a Mon Sep 17 00:00:00 2001
From: Lendemor <thomas.brandeho@gmail.com>
Date: Sat, 28 May 2016 10:55:34 +0200
Subject: [PATCH] fixed some uninitialized value and bad deletion of pointer

---
 generators/anselme.cpp      | 22 +++++++++++-----------
 generators/test_library.cpp | 36 ++++++++++++++++++++++++++++++++++++
 src/map.cpp                 |  2 +-
 src/mapscene.cpp            |  2 +-
 src/mapscene.h              |  2 +-
 src/simulation.cpp          |  8 ++------
 6 files changed, 52 insertions(+), 20 deletions(-)
 create mode 100644 generators/test_library.cpp

diff --git a/generators/anselme.cpp b/generators/anselme.cpp
index a79fd4f..4d36f79 100644
--- a/generators/anselme.cpp
+++ b/generators/anselme.cpp
@@ -7,25 +7,25 @@
 
 extern "C" void generate(Map *mapPtr)
 {
-	Map &map = *mapPtr;
-	int w = map.getWidth();
-	int h = map.getHeight();
-	int n = map.getNbTeams();
-        int i, j, k;
+    Map &map = *mapPtr;
+    int w = map.getWidth();
+    int h = map.getHeight();
+    int n = map.getNbTeams();
+    int i, j, k;
 	
-	for(i=0; i<n; i++)
-		map.team(i) = Coord((w/(n*2))*(1+i*2), h/2);
+    for(i=0; i<n; i++)
+        map.team(i) = Coord((w/(n*2))*(1+i*2), h/2);
 	
-        int r = h;
-        if(n != 0)
-                r = (w/n < h ? w/n : h)/2;
+    int r = h;
+    if(n != 0)
+        r = (w/n < h ? w/n : h)/2;
 
 	//génération de la carte
 	for (i=0;i<w;i++){
 		for(j=0;j<h;j++){
 			int d = std::max(w, h);
 			if(n == 0)
-                                d = h;
+                d = h;
 			for(k=0; k<n; k++){
 				d = std::min(d, map.team(k).dist(i, j));
 				if(!d)
diff --git a/generators/test_library.cpp b/generators/test_library.cpp
new file mode 100644
index 0000000..bb4e3a7
--- /dev/null
+++ b/generators/test_library.cpp
@@ -0,0 +1,36 @@
+#include <map.h>
+#include <cmath>
+#include <cstdlib>
+#include <algorithm>
+
+// g++ -shared test_library.cpp -o test_library.so -I../src -fPIC
+
+extern "C" void generate(Map *mapPtr)
+{
+    Map &map = *mapPtr;
+    int w = map.getWidth();
+    int h = map.getHeight();
+    int n = map.getNbTeams();
+    int i, j, k;
+
+    for(i=0;i<w;i++){
+        for(j=0;j<h;j++){
+            map[i][j].type = GRASS;
+        }
+    }
+
+    for(i=0; i<n; i++)
+        map.team(i) = Coord((w/(n*2))*(1+i*2), h/2);
+
+    Coord north = Coord(NORTH);
+    for(i=0; i<n; i++){
+//        Coord &spawn = map.team(i);
+        Coord lib(map.team(i));
+        lib+=north;
+        lib+=north;
+        map[map.team(i)].type=SPAWN;
+        map[map.team(i)].data.nbRes = 1;
+        map[lib].type=LIBRARY;
+        map[lib].data.knowledge = new char[LIBRARY_SIZE];
+    }
+}
diff --git a/src/map.cpp b/src/map.cpp
index e14baba..fd737eb 100644
--- a/src/map.cpp
+++ b/src/map.cpp
@@ -18,7 +18,7 @@ Map::Map(int nbTeams, int width, int height) :
 
 Map::~Map()
 {
-    delete m_map;
+    delete[] m_map;
     if(m_nbTeams)
         delete m_teams;
 }
diff --git a/src/mapscene.cpp b/src/mapscene.cpp
index da9419e..e41c3e9 100644
--- a/src/mapscene.cpp
+++ b/src/mapscene.cpp
@@ -38,7 +38,7 @@ MapScene::~MapScene()
         glDeleteVertexArrays(1, &m_vao);
         m_vao = 0;
     }
-    delete m_teamColors;
+    delete[] m_teamColors;
 }
 
 void MapScene::updatePixel(const Coord &c)
diff --git a/src/mapscene.h b/src/mapscene.h
index c58b421..222e919 100644
--- a/src/mapscene.h
+++ b/src/mapscene.h
@@ -11,7 +11,7 @@
 struct MapScene : public Map, public BasicScene
 {
 public:
-    MapScene(int n, int w, int h=0) : Map(n, w, h), m_teamColors(new TeamColor[n]) {}
+    MapScene(int n, int w, int h=0) : Map(n, w, h), m_teamColors(new TeamColor[n]),m_vao(0),m_vbo(0)  {}
 
     ~MapScene();
 
diff --git a/src/simulation.cpp b/src/simulation.cpp
index ac948ca..5662170 100644
--- a/src/simulation.cpp
+++ b/src/simulation.cpp
@@ -37,17 +37,15 @@ void Simulation::update()
         if(t.updateSpawn())
         {
             Coord spawnPos = p_map->team(i) + Coord(Dir(rand()%4));
-            std::cout << p_map->getPixel(spawnPos).type << std::endl;
             if(PixelProperty::isWalkable(p_map->getPixel(spawnPos).type))
             {
                 Dude *dude = new Dude(spawnPos,p_map,i);
                 (*p_map)[spawnPos].data.dudePtr = dude;
                 p_map->updatePixel(spawnPos);
                 m_dudes.push_back(dude);
-            }
+            }/*
             else
-                std::cout << "Unpopable" << std::endl;
-                // TODO check other case or delay the spawning
+                // TODO check other case or delay the spawning*/
         }
     }
 }
@@ -213,8 +211,6 @@ void Simulation::handleAction(const Action &action, Dude *dude)
             }
             else{
                 target.writeBook(action.com_data);
-                // TODO: understand what the fuck this line is doing bis
-                //memcpy(target.data.knowledge + action->com_data.flag, action->com_data.data, COM_SIZE);
                 dude->setSuccess(true);
             }
             break;